Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hf and multimodal clip #1921

Closed
wants to merge 11 commits into from
Closed

hf and multimodal clip #1921

wants to merge 11 commits into from

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Sep 22, 2023

multimodal clip is in canary because of torchtext dependency so this adds the hf version

Notably this PR also makes it possible to support dict based inputs to get_module() which is very common in HF code

Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msaroufim
Copy link
Member Author

No space left on device seems like another upstream issue

@msaroufim
Copy link
Member Author

Ok I think the problem is example_inputs is a dict instead of a list so will need to unpack it correctly in the torchbench tests

@facebook-github-bot
Copy link
Contributor

@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@msaroufim msaroufim temporarily deployed to docker-s3-upload September 26, 2023 02:26 — with GitHub Actions Inactive
@msaroufim msaroufim temporarily deployed to docker-s3-upload September 26, 2023 02:26 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@msaroufim merged this pull request in 6fef32d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants