-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hf and multimodal clip #1921
hf and multimodal clip #1921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
937c3a2
to
83bafe4
Compare
No space left on device seems like another upstream issue |
Ok I think the problem is |
@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@msaroufim merged this pull request in 6fef32d. |
multimodal clip is in canary because of torchtext dependency so this adds the hf version
Notably this PR also makes it possible to support dict based inputs to
get_module()
which is very common in HF code