Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout repo submodules recursively #1937

Closed
wants to merge 1 commit into from
Closed

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Sep 26, 2023

In bisection workflow, we found sometimes it fails to checkout recursive modules with git checkout --recurse-submodules, so we are adding another git submodule update --init --recursive command to make sure all submodules are being checked out.

Failed example workflow: https://github.com/pytorch/benchmark/actions/runs/6104757433

Successful workflow: https://github.com/pytorch/benchmark/actions/runs/6313591947/job/17141994764

@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload September 26, 2023 14:01 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload September 26, 2023 14:01 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 64409d5.

@xuzhao9 xuzhao9 deleted the xz9/improve-bisection branch September 26, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants