Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[userbenchmark] Fix JSON file format Torch-TRT #1998

Closed
wants to merge 1 commit into from
Closed

[userbenchmark] Fix JSON file format Torch-TRT #1998

wants to merge 1 commit into from

Conversation

gs-olive
Copy link
Contributor

  • Remove error message strings in JSON, opting for -1.0 as the error code instead
  • Add support for graph breaks metric in benchmark JSON
  • A future PR will add separate .txt files for each erroring model

@gs-olive
[userbenchmark] Fix JSON file format Torch-TRT
bf981d9 
- Remove error message strings in JSON, opting for -1.0 as the error
code instead
- A future PR will add separate `.txt` files for each erroring model
@gs-olive gs-olive temporarily deployed to docker-s3-upload October 19, 2023 22:56 — with GitHub Actions Inactive
@gs-olive gs-olive temporarily deployed to docker-s3-upload October 19, 2023 22:56 — with GitHub Actions Inactive
@gs-olive gs-olive mentioned this pull request Oct 19, 2023
Closed
xuzhao9
xuzhao9 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Will test it after getting merged.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in f953f81.

@gs-olive
Copy link
Contributor Author

Hi @xuzhao9 - thank you for the help with this - the benchmarks seem to be running well now! I am wondering how I can save error message logs effectively so they will reflect in the Github artifact? Would it suffice to save them as .txt logs in the .userbenchmark/torch_trt folder?

@xuzhao9
Copy link
Contributor

xuzhao9 commented Oct 23, 2023

@gs-olive Yes, everything under the .userbenchmark/torch_trt folder will be packaged into the Github artifact as a zip.

@gs-olive
Copy link
Contributor Author

Added the improvements in #2006 and #2007!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuzhao9 xuzhao9 xuzhao9 approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @facebook-github-bot @xuzhao9