Default to supported model batch size instead of metadata if batch size not specified #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze not specified [ghstack-poisoned]
eellison
added a commit
that referenced
this pull request
Oct 26, 2023
…ze not specified ghstack-source-id: dacb21b05bb4ffd664f957a18e0060c426988330 Pull Request resolved: #2015
eellison
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
eellison
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xmfan
reviewed
Oct 27, 2023
xmfan
approved these changes
Oct 27, 2023
msaroufim
approved these changes
Oct 27, 2023
…if batch size not specified" This was breaking stable_diffusion_unet. [ghstack-poisoned]
eellison
added a commit
that referenced
this pull request
Oct 27, 2023
…ze not specified ghstack-source-id: 9650512d1875e64cdbbe53a8259f3d9b9cbe2674 Pull Request resolved: #2015
eellison
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
eellison
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@pytorchbot merge |
xuzhao9
approved these changes
Oct 27, 2023
xuzhao9
reviewed
Oct 27, 2023
…if batch size not specified" This was breaking stable_diffusion_unet. [ghstack-poisoned]
eellison
added a commit
that referenced
this pull request
Oct 27, 2023
…ze not specified ghstack-source-id: 037c67ddab28909e96d395f87bac632cc664b7c8 Pull Request resolved: #2015
eellison
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
eellison
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@eellison Can you help import this PR to fbcode so that we can land it? Sorry but pytorch/benchmark does not use GH first for now. |
|
@eellison has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
imported ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This was breaking stable_diffusion_unet.
Differential Revision: D50747937