detectron2: require coco2017-minimal data #2022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like detectron2 requires coco2017-minimal data. It gets installed with vision-maskrcnn, but if you want to install requirements only for one model we need the installer scripts for the detectron models to download coco2017-minimal.
davidberard98
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
davidberard98
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
approved these changes
Nov 2, 2023
| @@ -55,6 +55,7 @@ def remove_tools_directory(): | |||
|
|
|||
| def install_detectron2(model_name, model_dir): | |||
| s3_utils.checkout_s3_data("INPUT_TARBALLS", "coco128.tar.gz", decompress=True) | |||
There was a problem hiding this comment.
I think we could remove this? I remember detectron2 models only requires coco2017-minimal, not coco128 - I don't remember the details though.
There was a problem hiding this comment.
I grepped for coco128 and couldn't find anything other than instances of checkout_s3_data, so I think you're right - will do that.
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
davidberard98
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
davidberard98
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@davidberard98 merged this pull request in 1e03c23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like detectron2 requires coco2017-minimal data. It gets installed with vision-maskrcnn, but if you want to install requirements only for one model we need the installer scripts for the detectron models to download coco2017-minimal.