Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 01-ai/Yi-6B #2037

Closed
wants to merge 3 commits into from
Closed

Add 01-ai/Yi-6B #2037

wants to merge 3 commits into from

Conversation

MaanavD
Copy link
Contributor

@MaanavD MaanavD commented Nov 13, 2023

Add the model to canary as its CPU test exceeds time limit and GPU test will OOM on A100.

@MaanavD MaanavD changed the title Attempting to add yi. OOM for now & testing Attempting to add 01-ai/Yi-6B. OOM for now & testing Nov 13, 2023
@MaanavD MaanavD changed the title Attempting to add 01-ai/Yi-6B. OOM for now & testing Add 01-ai/Yi-6B Nov 13, 2023
@@ -86,7 +87,7 @@ def __init__(self, name, test, device, batch_size=None, extra_args=[]):
config.num_buckets = 128
class_ctor = getattr(transformers, class_models[name][3])
kwargs = {}
if name == "hf_Falcon_7b" or name == "hf_MPT_7b_instruct" or name == "phi_1_5":
if name == "hf_Falcon_7b" or name == "hf_MPT_7b_instruct" or name == "phi_1_5" or name == "hf_Yi":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better readability, let's have a list containing all the models require remote code and test if name in remote_code_required.

@MaanavD MaanavD marked this pull request as ready for review November 15, 2023 07:59
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pranavsharma
Copy link
Contributor

I don't think our goal is to upload models to the canary folder directly. Our internal benchmark scripts/tools don't pick up models from the canary folder.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in d1d71d5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants