Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bisection routine by creating GitHub issue only when the bisection is successful #2050

Closed
wants to merge 6 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Nov 20, 2023

This is to resolve the noisy issues of the V3 nightly workflow.
When a regression is detected, we will first kick off a bisection workflow, and only create the GitHub issue when the bisection workflow fails or finds the root cause commit. If the bisection succeeds, but it does not find any result, we will not create an issue.

Test plan:
https://github.com/pytorch/benchmark/actions/runs/7506472200

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 4ffb8a9.

@xuzhao9 xuzhao9 deleted the xz9/improve-v3-bisect branch January 26, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants