Pin rotary-embedding-torch to 0.3.3 #2061
Conversation
Summary: A different rotary-embedding-torch version may cause a graph break count difference in PT2 tests, see pytorch/pytorch#114598
desertfire
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
desertfire
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
|
LGTM, but I wonder if imo we should have a policy of updating those dependencies say every 6 month or so (testing against the same 0.3.3 in 2025 would be somewhat moot, wouldn't it?) |
Is there an upstream PR in rotary-embedding-torch to fix the graph break issue? I am thinking to add a link to an upstream PR in the |
|
I don't have a plan to fix upstream rotary-embedding-torch. Have some kind of scheduled pin upgrade sounds like the right thing to do here, but it can take quite some effort given how many dependent libs we may end up with for the whole torchbench. It probably makes sense to focus on hardening torch.compile itself and eventually we will see less and less surprises like this. |
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@desertfire merged this pull request in 99944a2. |
Summary: A different rotary-embedding-torch version may cause a graph break count difference in PT2 tests, see pytorch/pytorch#114598 for details