Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle OSError in test_bench script #2090

Closed
wants to merge 9 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Dec 18, 2023

Handle subprocess segmentation fault error in the test_bench script.

Example:

python run_benchmark.py test_bench -m yolov3 -d cuda -t train
{
    "name": "test_bench",
    "environ": {
        "pytorch_git_version": "f13a21cce50586b74c882ec8e9ef38d60458484e",
        "pytorch_version": "2.2.0.dev20231213+cu118",
        "device": "Tesla T4"
    },
    "metrics": {
        "model=yolov3, test=eval, device=cuda, bs=None, extra_args=[], metric=latencies": "Subprocess terminates with code 11",
        "model=yolov3, test=eval, device=cuda, bs=None, extra_args=[], metric=cpu_peak_mem": "Subprocess terminates with code 11",
        "model=yolov3, test=eval, device=cuda, bs=None, extra_args=[], metric=gpu_peak_mem": "Subprocess terminates with code 11"
    }
}

Nightly docker build workflow: https://github.com/pytorch/benchmark/actions/runs/7257082609

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in c64a436.

@xuzhao9 xuzhao9 deleted the xz9/test_bench_handle_oss branch December 19, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants