Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[userbenchmark] Move Torch-TRT install to file #2092

Closed
wants to merge 1 commit into from

Conversation

gs-olive
Copy link
Contributor

  • Add custom installer support for userbenchmark testing
  • Add support for installing Torch-TRT outside of main container installs for nightly runs
  • Add necessary hooks and subprocess commands in code

- Add custom installer support for userbenchmark testing
- Add support for installing Torch-TRT outside of main container
installs for nightly runs
- Add necessary hooks and subprocess commands in code
@xuzhao9
Copy link
Contributor

xuzhao9 commented Dec 18, 2023

Could you please also help remove the torch_trt installation at cuda_utils.py? https://github.com/pytorch/benchmark/blob/main/utils/cuda_utils.py#L98

Never mind, saw it has been added.

Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 11376ae.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants