Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bisection fix and dockerfile improvements #2138

Closed
wants to merge 14 commits into from
Closed

Bisection fix and dockerfile improvements #2138

wants to merge 14 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Jan 27, 2024 •
edited
Loading

  1. Fix a bug in the GitHub issue generation.
  2. Improve the nightly dockerfile by using the upstream pytorch/builder scripts
  3. Create a new workflow for building the base GCP image

Test Plan:
https://github.com/pytorch/benchmark/actions/runs/7688881775
https://github.com/pytorch/benchmark/actions/runs/7688880409

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xuzhao9 xuzhao9 changed the title Another bisection fix. Bisection fix and dockerfile improvements Jan 29, 2024
@xuzhao9 xuzhao9 requested a review from atalman January 29, 2024 17:48
@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 05f99ee.

@xuzhao9 xuzhao9 mentioned this pull request Jan 29, 2024
Closed
@xuzhao9 xuzhao9 deleted the xz9/fix-bisect branch January 29, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman Awaiting requested review from atalman

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuzhao9 @facebook-github-bot