Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the GitHub issue report #2141

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/build-gcp-docker.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
name: TorchBench Nightly GCP Base Docker Build
on:
workflow_dispatch:
inputs:
nightly_date:
description: "PyTorch nightly version"
required: false

env:
WITH_PUSH: "true"

jobs:
build-push-docker:
if: ${{ github.repository_owner == 'pytorch' }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/userbenchmark-regression-detector.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ jobs:
uses: peter-evans/create-issue-from-file@v4
with:
title: Optim Perf Signal Detected by TorchBench CI on ${{ env.TORCHBENCH_REGRESSION_DETECTED }}
token: ${{ secrets.TORCHBENCH_ACCESS_TOKEN }}
content-filepath: ./benchmark/gh-issue.md
labels: |
torchbench-perf-report
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/v2-bisection.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ jobs:
- name: Create the github issue
if: env.TORCHBENCH_PERF_BISECTION_NONEMPTY_SIGNAL
uses: peter-evans/create-issue-from-file@v4
token: ${{ secrets.TORCHBENCH_ACCESS_TOKEN }}
with:
title: V2 Performance Signal Detected by TorchBench CI on ${{ env.TORCHBENCH_PERF_BISECTION_NONEMPTY_SIGNAL }}
content-filepath: ./bisection-result/gh-issue.md
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/v3-bisection.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ jobs:
continue-on-error: true
if: env.TORCHBENCH_BISECTION_COMMIT_FOUND_OR_FAILED
uses: peter-evans/create-issue-from-file@v4
token: ${{ secrets.TORCHBENCH_ACCESS_TOKEN }}
with:
title: V3 Performance Signal Detected by TorchBench Userbenchmark "torch-nightly" on ${{ env.TORCHBENCH_BISECTION_COMMIT_FOUND_OR_FAILED }}
content-filepath: ./benchmark/gh-issue.md
Expand Down
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,29 +11,29 @@ except for the torch products which are intended to be installed separately so
different torch versions can be benchmarked.

### Using Pre-built Packages
We support Python 3.8+, and 3.10 is recommended. Conda is optional but suggested. To start with Python 3.10 in conda:
We support Python 3.8+, and 3.11 is recommended. Conda is optional but suggested. To start with Python 3.11 in conda:
```
# Using your current conda environment:
conda install -y python=3.10
conda install -y python=3.11

# Or, using a new conda environment:
conda create -n torchbenchmark python=3.10
conda create -n torchbenchmark python=3.11
conda activate torchbenchmark
```

If you are running NVIDIA GPU tests, we support CUDA 11.8+, and use CUDA 11.8 as default:
If you are running NVIDIA GPU tests, we support both CUDA 11.8 and 12.1, and use CUDA 12.1 as default:
```
conda install -y -c pytorch magma-cuda118
conda install -y -c pytorch magma-cuda121
```

Then install pytorch, torchvision, and torchaudio using conda:
```
conda install pytorch torchvision torchaudio pytorch-cuda=11.8 -c pytorch-nightly -c nvidia
conda install pytorch torchvision torchaudio pytorch-cuda=12.1 -c pytorch-nightly -c nvidia
```
Or use pip:
(but don't mix and match pip and conda for the torch family of libs! - [see notes below](#notes))
```
pip install --pre torch torchvision torchaudio -i https://download.pytorch.org/whl/nightly/cu118
pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cu121
```

Install the benchmark suite, which will recursively install dependencies for all the models. Currently, the repo is intended to be installed from the source tree.
Expand Down
Loading