Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing batch.pt file for functorch_maml_omniglot #2145

Closed

Conversation

JasonMts
Copy link
Contributor

@JasonMts JasonMts commented Jan 30, 2024

functorch_maml_omniglot tries to load some inputs from a file that it has not downloaded in its install.py. This should be done similarly to how it's done for maml_omniglot.

Testing before:

FileNotFoundError: [Errno 2] No such file or directory: 'benchmark/torchbenchmark/models/maml_omniglot/batch.pt'

(...)

benchmark/components/_impl/workers/subprocess_rpc.py:458: FileNotFoundError
========================================================================= short test summary info ==========================================================================
FAILED benchmark/test.py::TestBenchmark::test_functorch_maml_omniglot_check_device_cpu - FileNotFoundError: [Errno 2] No such file or directory
FAILED benchmark/test.py::TestBenchmark::test_functorch_maml_omniglot_eval_cpu - FileNotFoundError: [Errno 2] No such file or directory
FAILED benchmark/test.py::TestBenchmark::test_functorch_maml_omniglot_example_cpu - FileNotFoundError: [Errno 2] No such file or directory
FAILED benchmark/test.py::TestBenchmark::test_functorch_maml_omniglot_train_cpu - FileNotFoundError: [Errno 2] No such file or directory

and afterwards:

==================================================================== 4 passed, 384 deselected in 12.55s ====================================================================

@JasonMts JasonMts marked this pull request as ready for review January 30, 2024 22:00
Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in a005ea8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants