Added moondream and llava. #2154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All accuracy and tests are passing on A100 for both llava and moondream. |
MaanavD
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
MaanavD
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
MaanavD
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
MaanavD
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
xuzhao9
reviewed
Feb 20, 2024
|
|
||
| PATCH_DIR = os.path.join(os.path.dirname(os.path.abspath(__file__)), "patches") | ||
|
|
||
| def cache_model(name: str, **kwargs): | ||
| import transformers | ||
| model_config = eval(class_models[name][2]) | ||
| model_ctor = getattr(transformers, class_models[name][3]) | ||
| model_ctor.from_config(model_config, **kwargs) | ||
| print(model_config.__class__.__name__) | ||
| print("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~") |
There was a problem hiding this comment.
Are these prints for debugging purpose?
xuzhao9
reviewed
Feb 20, 2024
| model_ctor.from_config(model_config, **kwargs) | ||
| print(model_config.__class__.__name__) | ||
| print("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~") | ||
| if (model_config.__class__.__name__ is "PhiConfig" or "LlavaConfig"): |
There was a problem hiding this comment.
I am wondering why we can't use the same code from model_factory.py to determine whether from_config should be used?
There was a problem hiding this comment.
Causes errors w/ runs for other HF models (feel free to test & replicate)
MaanavD
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
MaanavD
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
|
The models have been added by #2176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.