Log the optimus graph transformation to the scuba #2163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
xuzhao9
approved these changes
Feb 13, 2024
mengluy0125
force-pushed
the
export-D53692344
branch
from
0b1dc28
to
a0333ff
Compare
mengluy0125
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
mengluy0125
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
mengluy0125
force-pushed
the
export-D53692344
branch
from
a0333ff
to
87d6f19
Compare
mengluy0125
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
mengluy0125
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
mengluy0125
force-pushed
the
export-D53692344
branch
from
87d6f19
to
27805bf
Compare
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
mengluy0125
force-pushed
the
export-D53692344
branch
from
27805bf
to
c581f1a
Compare
mengluy0125
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
mengluy0125
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
mengluy0125
force-pushed
the
export-D53692344
branch
from
c581f1a
to
7590e0e
Compare
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
mengluy0125
force-pushed
the
export-D53692344
branch
from
7590e0e
to
4d23fcd
Compare
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This pull request was exported from Phabricator. Differential Revision: D53692344 |
jackiexu1992
approved these changes
Feb 15, 2024
mengluy0125
added a commit
to mengluy0125/benchmark
that referenced
this pull request
Feb 15, 2024
Summary: X-link: pytorch/pytorch#119745 Current everstore upload logging may cuase excessive compilation time when the model has lots of graph breaks (post: https://fb.workplace.com/groups/257735836456307/permalink/633533465543207/), we here log the transformation only when the graph changed Reviewed By: jackiexu1992 Differential Revision: D53692344
mengluy0125
force-pushed
the
export-D53692344
branch
from
4d23fcd
to
aa703b1
Compare
mengluy0125
added a commit
to mengluy0125/pytorch
that referenced
this pull request
Feb 15, 2024
… the scuba (pytorch#119745) Summary: X-link: pytorch/benchmark#2163 Current everstore upload logging may cuase excessive compilation time when the model has lots of graph breaks (post: https://fb.workplace.com/groups/257735836456307/permalink/633533465543207/), we here log the transformation only when the graph changed Test Plan: # unit test ``` buck2 test //caffe2/test/inductor:group_batch_fusion ``` Buck UI: https://www.internalfb.com/buck2/8dc77120-76ea-41bf-83b4-ada88bf1e2c8 Test UI: https://www.internalfb.com/intern/testinfra/testrun/7036874622840948 Network: Up: 321KiB Down: 33MiB (reSessionID-5372a58f-8b66-43a9-82b4-ee23aeaa44b9) Jobs completed: 20. Time elapsed: 4:13.4s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) Tests finished: Pass 7. Fail 0. Fatal 0. Skip 0. Build failure 0 ``` buck2 test //caffe2/test/inductor:split_cat_fx_passes ``` Buck UI: https://www.internalfb.com/buck2/abc8b8f8-d240-47d3-ad9d-cae13b8e62d3 Test UI: https://www.internalfb.com/intern/testinfra/testrun/13229323926967362 Network: Up: 119KiB Down: 66KiB (reSessionID-8bdd34b3-159b-469f-9f00-8384620c13ea) Jobs completed: 28. Time elapsed: 3:02.9s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) Tests finished: Pass 11. Fail 0. Fatal 0. Skip 0. Build failure 0 # e2e baseline: f528209775 proposal: f531285723 scuba: https://fburl.com/scuba/workflow_signpost/7hamzr64 {F1456548774} Reviewed By: jackiexu1992 Differential Revision: D53692344
|
This pull request was exported from Phabricator. Differential Revision: D53692344 |
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
mengluy0125
added a commit
to mengluy0125/benchmark
that referenced
this pull request
Feb 15, 2024
Summary: X-link: pytorch/pytorch#119745 Current everstore upload logging may cuase excessive compilation time when the model has lots of graph breaks (post: https://fb.workplace.com/groups/257735836456307/permalink/633533465543207/), we here log the transformation only when the graph changed Reviewed By: jackiexu1992 Differential Revision: D53692344
mengluy0125
force-pushed
the
export-D53692344
branch
from
aa703b1
to
c3cb88a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53692344 |
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
Summary: X-link: pytorch/pytorch#119745 Current everstore upload logging may cuase excessive compilation time when the model has lots of graph breaks (post: https://fb.workplace.com/groups/257735836456307/permalink/633533465543207/), we here log the transformation only when the graph changed Reviewed By: jackiexu1992 Differential Revision: D53692344
mengluy0125
force-pushed
the
export-D53692344
branch
from
c3cb88a
to
eade729
Compare
mengluy0125
added a commit
to mengluy0125/pytorch
that referenced
this pull request
Feb 15, 2024
… the scuba (pytorch#119745) Summary: X-link: pytorch/benchmark#2163 Current everstore upload logging may cuase excessive compilation time when the model has lots of graph breaks (post: https://fb.workplace.com/groups/257735836456307/permalink/633533465543207/), we here log the transformation only when the graph changed Test Plan: # unit test ``` buck2 test //caffe2/test/inductor:group_batch_fusion ``` Buck UI: https://www.internalfb.com/buck2/8dc77120-76ea-41bf-83b4-ada88bf1e2c8 Test UI: https://www.internalfb.com/intern/testinfra/testrun/7036874622840948 Network: Up: 321KiB Down: 33MiB (reSessionID-5372a58f-8b66-43a9-82b4-ee23aeaa44b9) Jobs completed: 20. Time elapsed: 4:13.4s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) Tests finished: Pass 7. Fail 0. Fatal 0. Skip 0. Build failure 0 ``` buck2 test //caffe2/test/inductor:split_cat_fx_passes ``` Buck UI: https://www.internalfb.com/buck2/abc8b8f8-d240-47d3-ad9d-cae13b8e62d3 Test UI: https://www.internalfb.com/intern/testinfra/testrun/13229323926967362 Network: Up: 119KiB Down: 66KiB (reSessionID-8bdd34b3-159b-469f-9f00-8384620c13ea) Jobs completed: 28. Time elapsed: 3:02.9s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) Tests finished: Pass 11. Fail 0. Fatal 0. Skip 0. Build failure 0 # e2e baseline: f528209775 proposal: f531285723 scuba: https://fburl.com/scuba/workflow_signpost/7hamzr64 {F1456548774} Reviewed By: jackiexu1992 Differential Revision: D53692344
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This pull request was exported from Phabricator. Differential Revision: D53692344 |
mengluy0125
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
mengluy0125
added a commit
to mengluy0125/pytorch
that referenced
this pull request
Feb 15, 2024
… the scuba (pytorch#119745) Summary: X-link: pytorch/benchmark#2163 Current everstore upload logging may cuase excessive compilation time when the model has lots of graph breaks (post: https://fb.workplace.com/groups/257735836456307/permalink/633533465543207/), we here log the transformation only when the graph changed Test Plan: # unit test ``` buck2 test //caffe2/test/inductor:group_batch_fusion ``` Buck UI: https://www.internalfb.com/buck2/8dc77120-76ea-41bf-83b4-ada88bf1e2c8 Test UI: https://www.internalfb.com/intern/testinfra/testrun/7036874622840948 Network: Up: 321KiB Down: 33MiB (reSessionID-5372a58f-8b66-43a9-82b4-ee23aeaa44b9) Jobs completed: 20. Time elapsed: 4:13.4s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) Tests finished: Pass 7. Fail 0. Fatal 0. Skip 0. Build failure 0 ``` buck2 test //caffe2/test/inductor:split_cat_fx_passes ``` Buck UI: https://www.internalfb.com/buck2/abc8b8f8-d240-47d3-ad9d-cae13b8e62d3 Test UI: https://www.internalfb.com/intern/testinfra/testrun/13229323926967362 Network: Up: 119KiB Down: 66KiB (reSessionID-8bdd34b3-159b-469f-9f00-8384620c13ea) Jobs completed: 28. Time elapsed: 3:02.9s. Cache hits: 0%. Commands: 2 (cached: 0, remote: 0, local: 2) Tests finished: Pass 11. Fail 0. Fatal 0. Skip 0. Build failure 0 # e2e baseline: f528209775 proposal: f531285723 scuba: https://fburl.com/scuba/workflow_signpost/7hamzr64 {F1456548774} Reviewed By: jackiexu1992 Differential Revision: D53692344
|
This pull request has been merged in f5b2e50. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Current everstore upload logging may cuase excessive compilation time when the model has lots of graph breaks (post: https://fb.workplace.com/groups/257735836456307/permalink/633533465543207/), we here log the transformation only when the graph changed
Differential Revision: D53692344