Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add moondream and llava from huggingface transformers #2176

Closed
wants to merge 10 commits into from
Closed

Add moondream and llava from huggingface transformers #2176

wants to merge 10 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Feb 21, 2024 •
edited
Loading

For llava model:

  • The CPU accuracy test fail because of CI runner CPU memory OOM
  • The GPU accuracy test fail because of GPU CUDA OOM

@xuzhao9 xuzhao9 changed the title [WIP] Adding moondream and llava from huggingface transformers Add moondream and llava from huggingface transformers Feb 22, 2024
aaronenyeshi
aaronenyeshi approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 4c7b6ec.

@xuzhao9 xuzhao9 deleted the adding_moondream branch February 23, 2024 00:02
@xuzhao9 xuzhao9 mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronenyeshi aaronenyeshi aaronenyeshi approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xuzhao9 @facebook-github-bot @aaronenyeshi @MaanavD