Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user release benchmark so that we can run it on pull request #2489

Closed
wants to merge 6 commits into from
Closed

Add user release benchmark so that we can run it on pull request #2489

wants to merge 6 commits into from
+61 −0

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Oct 3, 2024

No description provided.

@xuzhao9
Copy link
Contributor

xuzhao9 commented Oct 4, 2024

LGTM, we could submit a test PR after this PR gets merged, and see if it will work.

In addition, we could add userbenchmark/ path to path-ignore/ at https://github.com/pytorch/benchmark/blob/main/.github/workflows/pr-test.yml#L5, this will save some CI resource by skip testing the models on userbenchmark changes.

xuzhao9
xuzhao9 approved these changes Oct 4, 2024
View reviewed changes
.github/workflows/userbenchmark-a100-release.yml Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@atalman merged this pull request in bde2401.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuzhao9 xuzhao9 xuzhao9 approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atalman @xuzhao9 @facebook-github-bot