Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A simple install command gives everything a user need #7460

Open
larryliu0820 opened this issue Dec 30, 2024 · 0 comments · Fixed by #7473
Open

A simple install command gives everything a user need #7460

larryliu0820 opened this issue Dec 30, 2024 · 0 comments · Fixed by #7473
Labels
user experience reducing friction for users

Comments

@larryliu0820
Copy link
Contributor

  • We should use pip install . after pulling down all code from github. (not install_requirements.sh, at least not in official releases)
    That command by default build xnnpack and pybind.
  • If a user tries to lower to other backends that are not built by default, we should give graceful error messages.
@larryliu0820 larryliu0820 converted this from a draft issue Dec 30, 2024
@larryliu0820 larryliu0820 changed the title A simple command gives everything a user need A simple install command gives everything a user need Dec 30, 2024
@byjlw byjlw added the user experience reducing friction for users label Dec 30, 2024
mergennachin added a commit that referenced this issue Jan 2, 2025
@mergennachin
Install torchao by default
e981341 
Summary:

Now that torchao is not experimental anymore, we can rely on torchao directly via git submodule.

Part of #7460
This was referenced Jan 2, 2025
Merged
Merged
@mergennachin mergennachin moved this from To triage to In progress in ExecuTorch DevX improvements Jan 2, 2025
mergennachin added a commit that referenced this issue Jan 2, 2025
@mergennachin
Install torchao by default (#7470)
a861294 
Summary:

Now that torchao is not experimental anymore, we can rely on torchao directly via git submodule.

Part of #7460
@github-project-automation github-project-automation bot moved this from In progress to Done in ExecuTorch DevX improvements Jan 3, 2025
@mergennachin mergennachin moved this from Done to In progress in ExecuTorch DevX improvements Jan 3, 2025
@mergennachin mergennachin reopened this Jan 3, 2025
@github-project-automation github-project-automation bot moved this from In progress to Backlog in ExecuTorch DevX improvements Jan 3, 2025
@mergennachin mergennachin moved this from Backlog to In progress in ExecuTorch DevX improvements Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
user experience reducing friction for users
Projects
ExecuTorch DevX improvements
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update install_requirements to install --pybind xnnpack by default. pytorch/executorch
3 participants
@mergennachin @byjlw @larryliu0820