Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build frameworks. #2413

Closed
wants to merge 1 commit into from
Closed

Build frameworks. #2413

wants to merge 1 commit into from

Conversation

shoumikhin
Copy link
Contributor

Summary: .

Reviewed By: huydhn

Differential Revision: D54791338

Copy link

pytorch-bot bot commented Mar 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2413

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 97de0f3 with merge base bdc8338 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54791338

@@ -0,0 +1,46 @@
name: Build ExecuTorch demo apps
Copy link
Contributor

@huydhn huydhn Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think let's not create a new workflow if it's not needed. We can use https://github.com/pytorch/executorch/blob/main/.github/workflows/app-build.yml with build-ios as a different job there because the list of triggers are pretty much the same.

If you think the name app-build is not appropriate anymore, we could decide on a better name there.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54791338

7 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54791338

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54791338

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54791338

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54791338

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54791338

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54791338

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54791338

Summary:
Pull Request resolved: #2413

bypass-github-export-checks

Reviewed By: huydhn

Differential Revision: D54791338
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54791338

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 94517f0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants