-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android-release-artifact only trigger if AAR doesn't exist #6248
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6248
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit dc7f89d with merge base e342a92 (): NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shell: bash | ||
run: | | ||
VERSION="${{ inputs.version }}" | ||
if curl -I "https://ossci-android.s3.amazonaws.com/executorch/release/${VERSION}/executorch.aar" | grep "200 OK"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we need to verify the checksum here too. If yes, that can only be done after you build the aar archive as part of the linux_job workflow. Let me know if that's the case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The AAR checksum is not deterministic because it’s a zip and it contains zip (jar). So not quite actionable here.
@kirklandsign merged this pull request in 500019a. |
Test: attempt 1, https://github.com/pytorch/executorch/actions/runs/11356171402, passed. attempt 2 https://github.com/pytorch/executorch/actions/runs/11356452635, correctly stopped.