Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android-release-artifact only trigger if AAR doesn't exist #6248

Closed
wants to merge 1 commit into from

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Oct 15, 2024

@kirklandsign kirklandsign requested a review from huydhn October 15, 2024 23:52
Copy link

pytorch-bot bot commented Oct 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6248

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit dc7f89d with merge base e342a92 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2024
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

shell: bash
run: |
VERSION="${{ inputs.version }}"
if curl -I "https://ossci-android.s3.amazonaws.com/executorch/release/${VERSION}/executorch.aar" | grep "200 OK"; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need to verify the checksum here too. If yes, that can only be done after you build the aar archive as part of the linux_job workflow. Let me know if that's the case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AAR checksum is not deterministic because it’s a zip and it contains zip (jar). So not quite actionable here.

@facebook-github-bot
Copy link
Contributor

@kirklandsign merged this pull request in 500019a.

@kirklandsign kirklandsign deleted the android-release-artifact-check-exist branch October 16, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants