Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPS] Add dim_order compat support #7420

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

digantdesai
Copy link
Contributor

Differential Revision: D67542995

Copy link

pytorch-bot bot commented Dec 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7420

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures

As of commit 4b476e5 with merge base 82763a9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67542995

@digantdesai digantdesai marked this pull request as draft December 20, 2024 22:09
@digantdesai digantdesai changed the title Add dim_order compat support [MPS] Add dim_order compat support Dec 20, 2024
digantdesai added a commit to digantdesai/executorch-1 that referenced this pull request Dec 21, 2024
Summary: Pull Request resolved: pytorch#7420

Differential Revision: D67542995
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67542995

@@ -219,7 +219,7 @@ def lower_module_and_test_output(
dynamic_shapes=dynamic_shapes,
edge_compile_config=EdgeCompileConfig(
_check_ir_validity=False,
_skip_dim_order=True, # TODO(T182928844): Delegate dim order op to backend.
_skip_dim_order=False, # TODO(T182928844): Delegate dim order op to backend.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing

Summary: Pull Request resolved: pytorch#7420

Differential Revision: D67542995
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67542995

@digantdesai digantdesai had a problem deploying to upload-benchmark-results December 21, 2024 09:05 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants