-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable mypy, part 1 #7442
Enable mypy, part 1 #7442
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7442
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 77434bd with merge base 2600cc8 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
8846628
to
ff010bc
Compare
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ff010bc
to
0d964b7
Compare
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: This is the first PR to enable MyPy typechecker. There are few next steps, but this can land as-is as a standalone PR. Will keep enabling in smaller batches, via directory by directory. Also side note, pyre-ignore can be migrated to "# type: ignore" since pyre is backwards compatible with mypy.
0d964b7
to
77434bd
Compare
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
there was some discrepancy between running lintrunner/mypy locally vs in CI. was succeeding locally but failing in CI, so couldn't figure out the rootcause for a while. apparently, i had to install executorch (via install_requirements.py) before running mypy, otherwise, it was getting confused. will merge soon once the internal tests pass. |
Summary:
This is the first PR to enable MyPy typechecker.
There are few next steps, but this can land as-is as a standalone PR.
Will keep enabling in smaller batches, via directory by directory.
Also side note, pyre-ignore can be migrated to "# type: ignore" since pyre is backwards compatible with mypy.
Summary
Fixes #7441
Test plan
Run lintrunner