Remove path that is not needed for SDPA decomp #7451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7451
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ef3f83e with merge base cb568fa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67561688 |
zonglinpeng
approved these changes
Jan 2, 2025
Summary: Since we changed the flow to run decomps before the quantizer, we don't need the extra SDPA path now (which was one of the points!). Remove it here. `ReplaceSafeSoftmaxWithSoftmax` is retained since it's used by Helios for now. Reviewed By: zonglinpeng Differential Revision: D67561688
mcremon-meta
force-pushed
the
export-D67561688
branch
from
f984fe2 to
ef3f83e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67561688 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since we changed the flow to run decomps before the quantizer, we don't need the extra SDPA path now (which was one of the points!). Remove it here.
ReplaceSafeSoftmaxWithSoftmaxis retained since it's used by Helios for now.Differential Revision: D67561688