Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle illegal character in benchmark configs filename #7461

Merged
merged 5 commits into from
Dec 31, 2024

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Dec 30, 2024

As reported by https://github.com/pytorch/executorch/actions/runs/12540463242/job/34967784456 that after #7433 (comment) landed, exporting some spec files are failing because of invalid filename, for example meta-llama/Llama-3.2-1B. The fix here is just to remove the illegal characters from the filename. Tthe upload script will use the JSON content, not the filename anyway.

Testing

Testing meta-llama/Llama-3.2-1B model on:

@huydhn huydhn requested a review from guangy10 December 30, 2024 20:36
Copy link

pytorch-bot bot commented Dec 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7461

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit 2f18c0b with merge base fc04436 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 30, 2024
@huydhn huydhn marked this pull request as ready for review December 30, 2024 20:38
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@guangy10 guangy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@huydhn
Copy link
Contributor Author

huydhn commented Dec 30, 2024

Let me wait a bit for the benchmark to finish to confirm the results on the dashboard. So far, exporting the spec is ok now.

@huydhn huydhn temporarily deployed to upload-benchmark-results December 30, 2024 21:32 — with GitHub Actions Inactive
@huydhn huydhn had a problem deploying to upload-benchmark-results December 30, 2024 21:35 — with GitHub Actions Failure
@huydhn huydhn temporarily deployed to upload-benchmark-results December 30, 2024 21:37 — with GitHub Actions Inactive
@huydhn huydhn temporarily deployed to upload-benchmark-results December 30, 2024 22:08 — with GitHub Actions Inactive
@huydhn huydhn temporarily deployed to upload-benchmark-results December 31, 2024 01:43 — with GitHub Actions Inactive
@huydhn huydhn temporarily deployed to upload-benchmark-results December 31, 2024 01:45 — with GitHub Actions Inactive
@huydhn huydhn had a problem deploying to upload-benchmark-results December 31, 2024 01:46 — with GitHub Actions Failure
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@huydhn huydhn merged commit 9a884a8 into main Dec 31, 2024
80 of 83 checks passed
@huydhn huydhn deleted the fix-wrong-benchmark-config-filename branch December 31, 2024 02:13
@huydhn huydhn temporarily deployed to upload-benchmark-results December 31, 2024 02:24 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants