-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle illegal character in benchmark configs filename #7461
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7461
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 4 PendingAs of commit 2f18c0b with merge base fc04436 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Let me wait a bit for the benchmark to finish to confirm the results on the dashboard. So far, exporting the spec is ok now. |
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
On the other hand, I think there is another small bug on Android spec file https://github.com/pytorch/executorch/actions/runs/12553877667/job/35002446700. This is unrelated to this issue though, so I'm going to push another fix for that. |
As reported by https://github.com/pytorch/executorch/actions/runs/12540463242/job/34967784456 that after #7433 (comment) landed, exporting some spec files are failing because of invalid filename, for example
meta-llama/Llama-3.2-1B
. The fix here is just to remove the illegal characters from the filename. Tthe upload script will use the JSON content, not the filename anyway.Testing
Testing
meta-llama/Llama-3.2-1B
model on: