Enable mypy lintrunner, Part 4 (util/*) #7496
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7496
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bc81349 with merge base 7a2dc47 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
.mypy.ini
Outdated
| ignore_missing_imports = True | ||
|
|
||
| [mypy-buck_util] | ||
| [mypy-docutils.*] |
There was a problem hiding this comment.
why these one has ignore missing imports=true? wasnt before? Same for pandas
There was a problem hiding this comment.
I am guessing to make linter pass?
There was a problem hiding this comment.
i just sorted alphabetically
and some third party libraries, it does the best effort to infer the types, like, follow_untyped_imports=True
if it can't traverse due to missing symbols, linters complains, so i'm just ignoring these imports altogether. ignore_missing_imports
docs/source/custom_directives.py
Outdated
| @@ -121,7 +121,7 @@ class SupportedProperties(BaseShield): | |||
| required_arguments = 1 | |||
| final_argument_whitespace = True | |||
|
|
|||
| def run(self) -> List[nodes.Node]: | |||
| def run(self, params, alt, _) -> List[nodes.Node]: | |||
There was a problem hiding this comment.
This is consistent with the base class signature. run is overriden method.
|
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mergennachin
force-pushed
the
lints_part_4
branch
from
00d60e4 to
bc81349
Compare
|
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Fixes #7441
REVIEW THIS COMMIT ONLY : Enable mypy lintrunner, Part 4 (util/*) 00d60e4
Ignore the first two commits, they are part of separate PRs.