Fix the use of PyTorch pin commit in MacOS #7558
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7558
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 023381e with merge base 39e8538 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
broken: https://github.com/pytorch/executorch/actions/runs/12681330349/job/35344881397?pr=7558#step:9:435
I don't like repeating the computer, but having green CI is the only point for this change, so I have to request changes. please feel free to ping me when it's fixed for expedited review
| @@ -40,6 +40,41 @@ install_pip_dependencies() { | |||
| popd || return | |||
| } | |||
|
|
|||
| install_domains() { | |||
There was a problem hiding this comment.
These functions were removed by #4826. This was wrong for CI job and we need to bring them back.
|
now we have distributed/triton import failures https://github.com/pytorch/executorch/actions/runs/12681512566/job/35345401675?pr=7558#step:9:50147 . leaving accept in place because we should be directionally correct at this point and I trust you not to ship a red PR |
Yeah, this is new. I will make sure to get to the bottom of this before landing the change. I need to compare the list of dependencies before (using PT nightly) and after this change (using PT built from source) |
|
Darn, a GitHub outage is happening https://www.githubstatus.com/incidents/plgzz71xn6zq, need to wait for this storm to pass while testing this locally |
|
It's working now, it turns out that nightly binaries are built with |
I missed this in #6564, we need to apply the same fix for MacOS and add a test to make sure that PyTorch built from the pin commit is used instead of nightly.