Optimized atan2, _softmax, cat, clamp, full, relu, remainder, permute_copy_out ops and updates to use memory_allocator #7567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding mean and where ops optimized on HiFi
* adding pow, remainder, minimum, maximum operators * adding pow, remainder, minimum, maximum operators
Adding quantized linear optimized versions for int8 and uint8
* Adding cat, full, permute_copy and relu ops (pytorch#34) * Adding cat, full, permute_copy * updating relu wrt new ref (pytorch#36) * Temporary memory allocation, replacing mallocs (pytorch#38) * Integrated temporary mem alloc functionality in place of malloc * Namespace related changes * Cleanup the main application * Adding atan2, softmax, clamp and remainder ops (pytorch#37) * Replaced malloc with temp_memory_allocator --------- Co-authored-by: nishpoonia <94543206+nishpoonia@users.noreply.github.com> Co-authored-by: Rushi-cad <gherderu@cadence.com>
* adding ET_KERNEL_CHECK for allocate_temp_memory * solving lint error * Removing redundant check
Adding _softmax, relu, permute etc
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7567
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fe5e7d7 with merge base 1bac885 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label "topic: not user facing" |
- fixing build issue on previous commit
Update functions_hifi.yaml
…d removing exec_ten uses
Incorporating review comments: removing nesting to check data type an…
kimishpatel
added
the
module: cadence
zonglinpeng
approved these changes
Jan 20, 2025
| @@ -172,6 +179,7 @@ int main(int argc, char** argv) { | |||
|
|
|||
| // Run the model. | |||
| Error status = method->execute(); | |||
|
|
|||
There was a problem hiding this comment.
please avoid empty line changes
| "${EXECUTORCH_ROOT}/kernels/portable/cpu/op_clone.cpp" | ||
| "${EXECUTORCH_ROOT}/kernels/portable/cpu/op_embedding.cpp" | ||
| "${EXECUTORCH_ROOT}/kernels/portable/cpu/op_full.cpp" | ||
| "${EXECUTORCH_ROOT}/kernels/portable/cpu/op_gt.cpp" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimized atan2, _softmax, cat, clamp, full, relu, remainder, permute_copy_out ops and updates to use memory_allocator
Test plan
Unit tested kernels