Add build-time config for threadpool size #7773
Open
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7773
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7ab3449 with merge base fedb035 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68401795 |
GregoryComer
added
topic: not user facing
release notes: build
Summary:
Add a preprocessor flag (ET_THREADPOOL_SIZE) and corresponding buck config ("executorch.threadpool_size") to set the default ET threadpool size.
The intent of this change is to allow users in very memory-constrained environments to opt in to a smaller threadpool to shave a small amount of additional memory. Even when measuring resident set size, the addition threads can add more than a Mb of peak memory.
I considered making this a parameter to get_threadpool, but it is not consistently usable, as it depends on who first instantiates the threadpool. As it's a shared resource, it seemed more prudent to make it a build-time configuration.
Differential Revision: D68401795
GregoryComer
force-pushed
the
export-D68401795
branch
from
786b93d to
7ab3449
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68401795 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a preprocessor flag (ET_THREADPOOL_SIZE) and corresponding buck config ("executorch.threadpool_size") to set the default ET threadpool size.
The intent of this change is to allow users in very memory-constrained environments to opt in to a smaller threadpool to shave a small amount of additional memory. Even when measuring resident set size, the addition threads can add more than a Mb of peak memory.
I considered making this a parameter to get_threadpool, but it is not consistently usable, as it depends on who first instantiates the threadpool. As it's a shared resource, it seemed more prudent to make it a build-time configuration.
Differential Revision: D68401795