Generic impl different ip datatypes #7835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of the same type. Else, the generic implementation will be called
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7835
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0e3aa6e with merge base 9a0b51c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
ckmadhira
force-pushed
the
generic_impl_different_ip_datatypes
branch
from
86868ff to
6c765ae
Compare
|
@zonglinpeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hsharma35
approved these changes
Jan 23, 2025
zonglinpeng
approved these changes
Jan 23, 2025
|
@zonglinpeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@zonglinpeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added conditions in sub operator to call the optimized kernels only when all the input and output datatypes are same. Else, the operator calls the generic unoptimized implementation.