Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versioning Docs #474

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Versioning Docs #474

merged 2 commits into from
Apr 4, 2019

Conversation

anmolsjoshi
Copy link
Contributor

Fixes #308

Description:
Added method to version docs

Successfully completed using this repo, here's a link to the generated docs.

Check list:

  • New tests are added (if a new feature is modified)
  • New doc strings: text and/or example code are in RST format
  • Documentation is updated (if required)

@anmolsjoshi anmolsjoshi requested a review from vfdev-5 April 4, 2019 06:06
@anmolsjoshi
Copy link
Contributor Author

@vfdev-5 please review and merge

vfdev-5
vfdev-5 approved these changes Apr 4, 2019
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Joshi !

@vfdev-5 vfdev-5 merged commit 9e6605b into pytorch:master Apr 4, 2019
@anmolsjoshi anmolsjoshi deleted the doc_versioning branch April 4, 2019 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anmolsjoshi @vfdev-5