Skip to content

Commit

Permalink
[BugFix] Fix none ref in during reduction (#1090)
Browse files Browse the repository at this point in the history
  • Loading branch information
@vmoens
vmoens authored Nov 14, 2024
1 parent db2b5e6 commit c11024e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tensordict/base.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10965,7 +10965,7 @@ def set_(x):
tgt = mb_unwrap_functional_tensor(new_thing)
src = mb_unwrap_functional_tensor(ragged_source)
tgt.nested_int_memo = src.nested_int_memo
else:
elif new_thing is not None:
_tensor_symint_registry[new_thing] = _tensor_symint_registry[
ragged_source
]
Expand Down

1 comment on commit c11024e

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'CPU Benchmark Results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: c11024e Previous: db2b5e6 Ratio
benchmarks/common/common_ops_test.py::test_membership_stacked_nested_last 75823.57871601981 iter/sec (stddev: 7.478124109300453e-7) 245268.0521368682 iter/sec (stddev: 3.363817368936713e-7) 3.23
benchmarks/common/common_ops_test.py::test_membership_stacked_nested_leaf_last 75922.64237507244 iter/sec (stddev: 8.535502349191083e-7) 248381.81812408732 iter/sec (stddev: 3.7180846978687137e-7) 3.27

This comment was automatically generated by workflow using github-action-benchmark.

CC: @vmoens

Please sign in to comment.