Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter setup copied from torchtune #34

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Add linter setup copied from torchtune #34

merged 1 commit into from
Feb 2, 2024

Conversation

wconstab
Copy link
Contributor

@wconstab wconstab commented Feb 2, 2024

note that you should install the pre-commit tool from dev-requirements.txt and then you can invoke pre-commit from the CLI to get the same linters/formatters applied locally as would be run under CI.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 2, 2024
@wconstab wconstab requested a review from wanchaol February 2, 2024 01:52
run 'pre-commit' command locally to invoke these linters, before
committing
Copy link
Contributor

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thanks for adding linters!

@wconstab wconstab merged commit 34f38d9 into main Feb 2, 2024
2 checks passed
@wconstab wconstab deleted the whc/lint branch February 2, 2024 05:40
lessw2020 pushed a commit that referenced this pull request Apr 18, 2024
note that you should install the pre-commit tool from
`dev-requirements.txt` and then you can invoke `pre-commit` from the CLI
to get the same linters/formatters applied locally as would be run under
CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants