Move to cuda unconditionally so pp-only run works #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
tianyu-l
approved these changes
Feb 9, 2024
| @@ -185,4 +185,6 @@ def parallelize_llama(model, world_mesh, parallel_dims, args): | |||
|
|
|||
| rank0_log("Applied FSDP to the model...") | |||
|
|
|||
| # redundant if FSDP is used, but ensure the model is on device consistently regardless with parallelisms were used | |||
There was a problem hiding this comment.
not sure if this is a grammar issue: "regardless with" -> "regardless of what"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.