Improve run_llama_train.sh args and add local-ranks-filter #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
tianyu-l
reviewed
Feb 9, 2024
Comment on lines
+13
to
+15
| PP=${PP:-"1"} | ||
| SP=${SP:-"1"} | ||
| DP=${DP:-"-1"} |
There was a problem hiding this comment.
I wonder where these are picked up. Shall we also add to the torchrun cmd? e.g. --pp_degree=${PP}
There was a problem hiding this comment.
oh, yea, i forgot to copy that part over. will fix.
tianyu-l
approved these changes
Feb 9, 2024
wconstab
commented
Feb 10, 2024
| DP=${DP:-"-1"} | ||
|
|
||
| # by default log just rank 0 output, | ||
| LOG_RANK=${LOG_RANK:-0} |
There was a problem hiding this comment.
I think one issue for my solution is that you can't easily disable 'log_rank' unless you comment out the --local-ranks-filter option
There was a problem hiding this comment.
gonna merge it this way, its probably easier to have rank0 by default and comment out than remember how to add the filter string in, but we can probably improve this.
wconstab
force-pushed
the
whc/logrank
branch
from
42d77fc to
9b9ee1f
Compare
lessw2020
pushed a commit
that referenced
this pull request
Apr 18, 2024
allows convenient switching of args w/o editing .sh file e.g. `LOG_RANK=1,2 ./run_llama_train.sh` `NGPU=2 SP=2 ./run_llama_train.sh`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows convenient switching of args w/o editing .sh file
e.g.
LOG_RANK=1,2 ./run_llama_train.shNGPU=2 SP=2 ./run_llama_train.sh