-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pyproject.toml
entirely
#126
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
==========================================
- Coverage 77.04% 74.22% -2.82%
==========================================
Files 32 33 +1
Lines 3001 3115 +114
==========================================
Hits 2312 2312
- Misses 689 803 +114 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks a lot! As far as I can see there's no need to update the documentation, right? (https://pygac.readthedocs.io/en/latest/installation.html)
The documentation should be good as it is. I just need to double check the scripts before this can be merged. |
You mean |
ah, good to know. But there is also |
Oh right, we need that one |
LGTM! |
This PR drops setup.py and uses pyproject.toml only.