Fix sdist tarball including unnecessary files #3030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on slack, I discovered that hatch/hatchling does not use the MANIFEST.in template file for what to include in an sdist. As such, it seems we have been including all files in the git repository when run in CI. Fortunately since this is from a fresh clone this was mostly only including a few extra files plus all the documentation source files, benchmark files, etc. Hatchling always includes READMEs and LICENSE files.
In this PR I've removed the unused MANIFEST.in file and make a custom section in pyproject.toml to explicitly say what files to include. Normally this would be
packages = ["satpy"]
but to preserve what the manifest file had I also included authors, changelog, security, and citation.The one major difference I've configured here is to NOT include the documentation. I can be convinced otherwise, but I just don't think they are necessary.The wheel file is unchanged and only includes the python package source.
AUTHORS.md
if not there already