You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note that in PR #21 tests have been added, including some for job cancellation. The main thing now is testing that a container is removed when a job in cancelled before it has started. This issue is now about implementing that, including finding a way to test it reliably.
The text was updated successfully, but these errors were encountered:
One approach to make this, is to add an option to create a Docker instance without starting it, e.g. when the schedule endpoint is called with a special query parameter (one that wouldn't be used as a setting), or perhaps a special header. Then the test can use it for testing this scenario.
Stopping jobs mostly works, but it has a number of cases to test.
Can you think of more corner-cases?
Especially in the first case, there might be various stages.
See also documentation on scrapyd's cancel endpoint.
Note that in PR #21 tests have been added, including some for job cancellation. The main thing now is testing that a container is removed when a job in cancelled before it has started. This issue is now about implementing that, including finding a way to test it reliably.
The text was updated successfully, but these errors were encountered: