Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TensorFlow dependency #241

Closed
wants to merge 0 commits into from
Closed

Fix TensorFlow dependency #241

wants to merge 0 commits into from

Conversation

nwittler
Copy link
Collaborator

What

Lock tf version to 2.14.1

Why

tf version 2.15 changed an interface to check for tensor types, resulting in
AttributeError: module 'tensorflow.python.framework.ops' has no attribute 'Tensor'

How

Update setup.py

Remarks

While unmaintained right now, this keeps dev functional.

Checklist

Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines for more details. You can mark an item as complete with the - [x] prefix

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions in the numpydoc style
  • Documentation - The tutorial style documentation has been updated to explain changes & new features
  • Notebooks - Example notebooks have been updated to incorporate changes and new features
  • Changelog - A short note on this PR has been added to the Upcoming Release section

@nwittler nwittler changed the title Lock tf version to 2.14.1 Fix TensorFlow dependency Jan 25, 2024
@nwittler nwittler marked this pull request as draft January 25, 2024 15:32
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48b7917) 76.67% compared to head (112c875) 76.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #241   +/-   ##
=======================================
  Coverage   76.67%   76.67%           
=======================================
  Files          38       38           
  Lines        5873     5873           
=======================================
  Hits         4503     4503           
  Misses       1370     1370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant