WebUI: disallow unnecessary quotes in property name #7057
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: CI - macOS | |
| on: [pull_request, push] | |
| permissions: | |
| actions: write | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | |
| cancel-in-progress: ${{ github.head_ref != '' }} | |
| jobs: | |
| ci: | |
| name: Build | |
| runs-on: macos-latest | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| libt_version: ["2.0.10", "1.2.19"] | |
| qbt_gui: ["GUI=ON", "GUI=OFF"] | |
| qt_version: ["6.7.0"] | |
| env: | |
| boost_path: "${{ github.workspace }}/../boost" | |
| libtorrent_path: "${{ github.workspace }}/../libtorrent" | |
| steps: | |
| - name: Checkout repository | |
| uses: actions/checkout@v4 | |
| - name: Install dependencies | |
| uses: Wandalen/wretry.action@v3 | |
| env: | |
| HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: 1 | |
| HOMEBREW_NO_INSTALL_CLEANUP: 1 | |
| with: | |
| attempt_delay: 20000 | |
| attempt_limit: 6 | |
| command: | | |
| brew update > /dev/null | |
| brew install \ | |
| cmake ninja \ | |
| openssl@3 zlib | |
| - name: Setup ccache | |
| uses: Chocobo1/setup-ccache-action@v1 | |
| with: | |
| store_cache: ${{ github.ref == 'refs/heads/master' }} | |
| update_packager_index: false | |
| ccache_options: | | |
| max_size=2G | |
| - name: Install boost | |
| env: | |
| BOOST_MAJOR_VERSION: "1" | |
| BOOST_MINOR_VERSION: "86" | |
| BOOST_PATCH_VERSION: "0" | |
| run: | | |
| boost_url="https://boostorg.jfrog.io/artifactory/main/release/${{ env.BOOST_MAJOR_VERSION }}.${{ env.BOOST_MINOR_VERSION }}.${{ env.BOOST_PATCH_VERSION }}/source/boost_${{ env.BOOST_MAJOR_VERSION }}_${{ env.BOOST_MINOR_VERSION }}_${{ env.BOOST_PATCH_VERSION }}.tar.gz" | |
| boost_url2="https://sourceforge.net/projects/boost/files/boost/${{ env.BOOST_MAJOR_VERSION }}.${{ env.BOOST_MINOR_VERSION }}.${{ env.BOOST_PATCH_VERSION }}/boost_${{ env.BOOST_MAJOR_VERSION }}_${{ env.BOOST_MINOR_VERSION }}_${{ env.BOOST_PATCH_VERSION }}.tar.gz" | |
| set +e | |
| curl -L -o "${{ runner.temp }}/boost.tar.gz" "$boost_url" | |
| tar -xf "${{ runner.temp }}/boost.tar.gz" -C "${{ github.workspace }}/.."; _exitCode="$?" | |
| if [ "$_exitCode" -ne "0" ]; then | |
| curl -L -o "${{ runner.temp }}/boost.tar.gz" "$boost_url2" | |
| tar -xf "${{ runner.temp }}/boost.tar.gz" -C "${{ github.workspace }}/.."; _exitCode="$?" | |
| fi | |
| mv "${{ github.workspace }}/.."/boost_* "${{ env.boost_path }}" | |
| - name: Install Qt | |
| uses: jurplel/install-qt-action@v4 | |
| with: | |
| version: ${{ matrix.qt_version }} | |
| archives: qtbase qtdeclarative qtsvg qttools | |
| # Not sure why Qt made a hard dependency on qtdeclarative, try removing it when Qt > 6.4.0 | |
| cache: true | |
| - name: Install libtorrent | |
| run: | | |
| git clone \ | |
| --branch v${{ matrix.libt_version }} \ | |
| --depth 1 \ | |
| --recurse-submodules \ | |
| https://github.com/arvidn/libtorrent.git \ | |
| ${{ env.libtorrent_path }} | |
| cd ${{ env.libtorrent_path }} | |
| cmake \ | |
| -B build \ | |
| -G "Ninja" \ | |
| -DBUILD_SHARED_LIBS=OFF \ | |
| -DCMAKE_BUILD_TYPE=RelWithDebInfo \ | |
| -DCMAKE_CXX_STANDARD=17 \ | |
| -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \ | |
| -DBOOST_ROOT="${{ env.boost_path }}" \ | |
| -Ddeprecated-functions=OFF | |
| cmake --build build | |
| sudo cmake --install build | |
| - name: Build qBittorrent | |
| run: | | |
| CXXFLAGS="$CXXFLAGS -DQT_FORCE_ASSERTS -Werror -Wno-error=deprecated-declarations" \ | |
| LDFLAGS="$LDFLAGS -gz" \ | |
| cmake \ | |
| -B build \ | |
| -G "Ninja" \ | |
| -DCMAKE_BUILD_TYPE=RelWithDebInfo \ | |
| -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \ | |
| -DBOOST_ROOT="${{ env.boost_path }}" \ | |
| -DTESTING=ON \ | |
| -DVERBOSE_CONFIGURE=ON \ | |
| -D${{ matrix.qbt_gui }} | |
| cmake --build build --target qbt_update_translations | |
| cmake --build build | |
| cmake --build build --target check | |
| - name: Prepare build artifacts | |
| run: | | |
| # create .dmg | |
| appName="qbittorrent" | |
| if [ "${{ matrix.qbt_gui }}" = "GUI=OFF" ]; then | |
| appName="qbittorrent-nox" | |
| fi | |
| # package | |
| pushd build | |
| PACKAGE_RETRY=0 | |
| while [ "$PACKAGE_RETRY" -lt "3" ]; do | |
| macdeployqt "$appName.app" -dmg -no-strip | |
| if [ -f "$appName.dmg" ]; then | |
| break | |
| fi | |
| sleep 5 | |
| PACKAGE_RETRY=$((PACKAGE_RETRY + 1)) | |
| echo "Retry $PACKAGE_RETRY..." | |
| done | |
| popd | |
| # prepare upload folder | |
| mkdir upload | |
| cp "build/$appName.dmg" upload | |
| mkdir upload/cmake | |
| cp build/compile_commands.json upload/cmake | |
| mkdir upload/cmake/libtorrent | |
| cp ${{ env.libtorrent_path }}/build/compile_commands.json upload/cmake/libtorrent | |
| - name: Upload build artifacts | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: qBittorrent-CI_macOS_${{ matrix.qbt_gui }}_libtorrent-${{ matrix.libt_version }}_Qt-${{ matrix.qt_version }} | |
| path: upload |