Send 204 when WebAPI response contains no data

Signed-off-by: Thomas Piccirello <thomas@piccirello.com>
qbittorrent · Sep 24, 2024 · 6a90fab · 6a90fab
1 parent 4555a46
commit 6a90fab
Showing 1 changed file with 21 additions and 14 deletions.
diff --git a/src/webui/webapplication.cpp b/src/webui/webapplication.cpp
@@ -358,25 +358,32 @@ void WebApplication::doProcessRequest()
     try
     {
         const APIResult result = controller->run(action, m_params, data);
-        switch (result.data.userType())
+        if (result.data.isNull())
         {
-        case QMetaType::QJsonDocument:
-            print(result.data.toJsonDocument().toJson(QJsonDocument::Compact), Http::CONTENT_TYPE_JSON);
-            break;
-        case QMetaType::QByteArray:
+            status(204);
+        }
+        else
+        {
+            switch (result.data.userType())
             {
-                const auto resultData = result.data.toByteArray();
-                print(resultData, (!result.mimeType.isEmpty() ? result.mimeType : Http::CONTENT_TYPE_TXT));
-                if (!result.filename.isEmpty())
+            case QMetaType::QJsonDocument:
+                print(result.data.toJsonDocument().toJson(QJsonDocument::Compact), Http::CONTENT_TYPE_JSON);
+                break;
+            case QMetaType::QByteArray:
                 {
-                    setHeader({u"Content-Disposition"_s, u"attachment; filename=\"%1\""_s.arg(result.filename)});
+                    const auto resultData = result.data.toByteArray();
+                    print(resultData, (!result.mimeType.isEmpty() ? result.mimeType : Http::CONTENT_TYPE_TXT));
+                    if (!result.filename.isEmpty())
+                    {
+                        setHeader({u"Content-Disposition"_s, u"attachment; filename=\"%1\""_s.arg(result.filename)});
+                    }
                 }
+                break;
+            case QMetaType::QString:
+            default:
+                print(result.data.toString(), Http::CONTENT_TYPE_TXT);
+                break;
             }
-            break;
-        case QMetaType::QString:
-        default:
-            print(result.data.toString(), Http::CONTENT_TYPE_TXT);
-            break;
         }
     }
     catch (const APIError &error)