Maintain 200 status code for existing APIs

This is to avoid introducing breaking changes. Without this change, these APIs would start returning a 204 due to their lack of response content.
qbittorrent · Nov 27, 2024 · aaa93cb · aaa93cb
1 parent 78fbcab
commit aaa93cb
Show file tree

Hide file tree

Showing 7 changed files with 135 additions and 1 deletion.
diff --git a/src/webui/api/appcontroller.cpp b/src/webui/api/appcontroller.cpp
@@ -123,6 +123,7 @@ void AppController::shutdownAction()
     {
         QCoreApplication::exit();
     });
+    setResult(u""_s);
 }
 
 void AppController::preferencesAction()
@@ -1157,6 +1158,8 @@ void AppController::setPreferencesAction()
 
     // Save preferences
     pref->apply();
+
+    setResult(u""_s);
 }
 
 void AppController::defaultSavePathAction()
@@ -1167,9 +1170,9 @@ void AppController::defaultSavePathAction()
 void AppController::sendTestEmailAction()
 {
     app()->sendTestEmail();
+    setResult(u""_s);
 }
 
-
 void AppController::getDirectoryContentAction()
 {
     requireParams({u"dirPath"_s});
@@ -1259,6 +1262,8 @@ void AppController::setCookiesAction()
     }
 
     Net::DownloadManager::instance()->setAllCookies(cookies);
+
+    setResult(u""_s);
 }
 
 void AppController::networkInterfaceListAction()

diff --git a/src/webui/api/authcontroller.cpp b/src/webui/api/authcontroller.cpp
@@ -46,11 +46,13 @@ AuthController::AuthController(ISessionManager *sessionManager, IApplication *ap
 void AuthController::setUsername(const QString &username)
 {
     m_username = username;
+    setResult(u""_s);
 }
 
 void AuthController::setPasswordHash(const QByteArray &passwordHash)
 {
     m_passwordHash = passwordHash;
+    setResult(u""_s);
 }
 
 void AuthController::loginAction()
@@ -99,6 +101,7 @@ void AuthController::loginAction()
 void AuthController::logoutAction() const
 {
     m_sessionManager->sessionEnd();
+    setResult(u""_s);
 }
 
 bool AuthController::isBanned() const

diff --git a/src/webui/api/rsscontroller.cpp b/src/webui/api/rsscontroller.cpp
@@ -53,6 +53,8 @@ void RSSController::addFolderAction()
     const nonstd::expected<void, QString> result = RSS::Session::instance()->addFolder(path);
     if (!result)
         throw APIError(APIErrorType::Conflict, result.error());
+
+    setResult(u""_s);
 }
 
 void RSSController::addFeedAction()
@@ -64,6 +66,8 @@ void RSSController::addFeedAction()
     const nonstd::expected<void, QString> result = RSS::Session::instance()->addFeed(url, (path.isEmpty() ? url : path));
     if (!result)
         throw APIError(APIErrorType::Conflict, result.error());
+
+    setResult(u""_s);
 }
 
 void RSSController::setFeedURLAction()
@@ -75,6 +79,8 @@ void RSSController::setFeedURLAction()
     const nonstd::expected<void, QString> result = RSS::Session::instance()->setFeedURL(path, url);
     if (!result)
         throw APIError(APIErrorType::Conflict, result.error());
+
+    setResult(u""_s);
 }
 
 void RSSController::removeItemAction()
@@ -85,6 +91,8 @@ void RSSController::removeItemAction()
     const nonstd::expected<void, QString> result = RSS::Session::instance()->removeItem(path);
     if (!result)
         throw APIError(APIErrorType::Conflict, result.error());
+
+    setResult(u""_s);
 }
 
 void RSSController::moveItemAction()
@@ -96,6 +104,8 @@ void RSSController::moveItemAction()
     const nonstd::expected<void, QString> result = RSS::Session::instance()->moveItem(itemPath, destPath);
     if (!result)
         throw APIError(APIErrorType::Conflict, result.error());
+
+    setResult(u""_s);
 }
 
 void RSSController::itemsAction()
@@ -130,6 +140,8 @@ void RSSController::markAsReadAction()
     {
         item->markAsRead();
     }
+
+    setResult(u""_s);
 }
 
 void RSSController::refreshItemAction()
@@ -140,6 +152,8 @@ void RSSController::refreshItemAction()
     RSS::Item *item = RSS::Session::instance()->itemByPath(itemPath);
     if (item)
         item->refresh();
+
+    setResult(u""_s);
 }
 
 void RSSController::setRuleAction()
@@ -151,6 +165,8 @@ void RSSController::setRuleAction()
 
     const auto jsonObj = QJsonDocument::fromJson(ruleDef).object();
     RSS::AutoDownloader::instance()->setRule(RSS::AutoDownloadRule::fromJsonObject(jsonObj, ruleName));
+
+    setResult(u""_s);
 }
 
 void RSSController::renameRuleAction()
@@ -161,6 +177,8 @@ void RSSController::renameRuleAction()
     const QString newRuleName {params()[u"newRuleName"_s].trimmed()};
 
     RSS::AutoDownloader::instance()->renameRule(ruleName, newRuleName);
+
+    setResult(u""_s);
 }
 
 void RSSController::removeRuleAction()
@@ -169,6 +187,8 @@ void RSSController::removeRuleAction()
 
     const QString ruleName {params()[u"ruleName"_s].trimmed()};
     RSS::AutoDownloader::instance()->removeRule(ruleName);
+
+    setResult(u""_s);
 }
 
 void RSSController::rulesAction()

diff --git a/src/webui/api/searchcontroller.cpp b/src/webui/api/searchcontroller.cpp
@@ -142,6 +142,8 @@ void SearchController::stopAction()
         searchHandler->cancelSearch();
         m_activeSearches.remove(id);
     }
+
+    setResult(u""_s);
 }
 
 void SearchController::statusAction()
@@ -215,6 +217,8 @@ void SearchController::deleteAction()
     searchHandler->cancelSearch();
     m_activeSearches.remove(id);
     m_searchHandlers.erase(iter);
+
+    setResult(u""_s);
 }
 
 void SearchController::downloadTorrentAction()
@@ -238,6 +242,8 @@ void SearchController::downloadTorrentAction()
             downloadHandler->deleteLater();
         });
     }
+
+    setResult(u""_s);
 }
 
 void SearchController::pluginsAction()
@@ -253,6 +259,8 @@ void SearchController::installPluginAction()
     const QStringList sources = params()[u"sources"_s].split(u'|');
     for (const QString &source : sources)
         SearchPluginManager::instance()->installPlugin(source);
+
+    setResult(u""_s);
 }
 
 void SearchController::uninstallPluginAction()
@@ -262,6 +270,8 @@ void SearchController::uninstallPluginAction()
     const QStringList names = params()[u"names"_s].split(u'|');
     for (const QString &name : names)
         SearchPluginManager::instance()->uninstallPlugin(name.trimmed());
+
+    setResult(u""_s);
 }
 
 void SearchController::enablePluginAction()
@@ -273,6 +283,8 @@ void SearchController::enablePluginAction()
 
     for (const QString &name : names)
         SearchPluginManager::instance()->enablePlugin(name.trimmed(), enable);
+
+    setResult(u""_s);
 }
 
 void SearchController::updatePluginsAction()
@@ -282,6 +294,8 @@ void SearchController::updatePluginsAction()
     connect(pluginManager, &SearchPluginManager::checkForUpdatesFinished, this, &SearchController::checkForUpdatesFinished);
     connect(pluginManager, &SearchPluginManager::checkForUpdatesFailed, this, &SearchController::checkForUpdatesFailed);
     pluginManager->checkForUpdates();
+
+    setResult(u""_s);
 }
 
 void SearchController::checkForUpdatesFinished(const QHash<QString, PluginVersion> &updateInfo)
@@ -300,6 +314,8 @@ void SearchController::checkForUpdatesFinished(const QHash<QString, PluginVersio
         LogMsg(tr("Updating plugin %1").arg(pluginName), Log::INFO);
         pluginManager->updatePlugin(pluginName);
     }
+
+    setResult(u""_s);
 }
 
 void SearchController::checkForUpdatesFailed(const QString &reason)

diff --git a/src/webui/api/torrentcreatorcontroller.cpp b/src/webui/api/torrentcreatorcontroller.cpp
@@ -244,4 +244,6 @@ void TorrentCreatorController::deleteTaskAction()
 
     if (!m_torrentCreationManager->deleteTask(id))
         throw APIError(APIErrorType::NotFound);
+
+    setResult(u""_s);
 }