Backport changes to v4.6.x #19582
Merged
Backport changes to v4.6.x #19582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
glassez
commented
Sep 8, 2023
•
glassez
commented
- PR Fix crash on application exit (Qt 6.5) #19169
- PR Don't set parent of "Add new torrent dialog" on macOS #19494
- PR Sync flag icons with upstream #19518
- PR "Add Tags" field for RSS rules in WebUI #19519
- PR Add button to copy library versions to clipboard #19526
- PR Enable DBUS cmake option on FreeBSD #19559
- PR Don't limit max RSS feed file size #19576
- PR Prevent torrent from being started unexpectedly #19597
- PR WebUI: fix missing error icon #19610
- PR Fix memory leaks #19650
- PR Don't forget to delete worker thread object #19655
- PR Filter out duplicate trackers when replacing #19656
- PR Add logging for some alerts #19662
- PR Double check whether database needs to be updated #19668
- PR Improve GUI behavior when adding multiple torrents #19670
And therefore its text is copyable.
Improves "Metadata received" stop condition handling by "Add new torrent" dialog. The problem is when "Metadata received" stop condition is set the metadata can still be received 0.1 sec before clicking the "OK" button so torrent is actually added with metadata and therefore it cannot respect "Metadata received" stop condition. The solution is to uncheck "Start torrent" checkbox once metadata is received. PR qbittorrent#19597. Closes qbittorrent#19583.
Fixes a couple of memory leaks (although not dangerous in practice, since we are talking about objects with a lifetime up to the end of the application) PR qbittorrent#19650. Closes qbittorrent#19632.
Specifically these alerts: * i2p_alert * session_error_alert PR qbittorrent#19662.
|
I want to add #19668 before merging this PR. |
Prevents qBittorrent from being failed to start after torrents database metadata is corrupted by one of the first releases of v4.5.x series. PR qbittorrent#19668. Closes qbittorrent#19622.
* Includes all 268 flags. * Upstream commit `a7b7c3c55560cb39d96e70324876e1bb5b1c625b` - (Release v6.11.0) * Flags source from (zip): https://github.com/lipis/flag-icons/releases/tag/v6.11.0 PR qbittorrent#19518.
xavier2k6
previously approved these changes
Oct 2, 2023
PR qbittorrent#19494. Closes qbittorrent#12849. Closes qbittorrent#12852. Closes qbittorrent#19072. --------- Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
Allows you to bring the main window to the front when one or more "Add new torrent" dialogs are open. Also allows you to minimize/maximize the "Add new torrent" dialog. PR qbittorrent#19670. Closes qbittorrent#17919.
Same.. 👍 |
xavier2k6
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.