-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebUI: fix missing error icon #19610
Conversation
you may have to change commit message....will leave that to others to decide but confirmed the issue & this PR fixes it. |
Do you mean I need to rebase commit and re-write commit message? I'm not a very good at English, what commit message it should be? |
Something like:
But don't worry about it. We can handle it when we merge it. Just leave it as is. |
Yes, in my understanding github support editing merge commit or squash commit's commit message. Thanks. |
git commit --amend -m "Fix missing error icon in WebUI" -m "Closes #18737."
git push --force |
This can be done be squashing merging... I'd like not to touch any commits, so reviewers won't need to review them again. |
do i also need to create following PRs to backport this change to 4.x?i saw a branch 4.6 and 4.5 |
I will add it in #19582 after it is merged. |
4.5 is EOL, AFAIK. |
@trim21 |
Closes #18737.
tested locally, working as expected