Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify Python executable path #19644

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

Chocobo1
Copy link
Member

Closes #19195.

@Chocobo1 Chocobo1 added the Search engine Issues related to the search engine/search plugins functionality label Sep 24, 2023
@Chocobo1 Chocobo1 added this to the 5.0 milestone Sep 24, 2023
// Python executable path
m_pythonExecutablePath.setPlaceholderText(tr("(Auto detect if empty)"));
m_pythonExecutablePath.setText(pref->getPythonExecutablePath().toString());
addRow(PYTHON_EXECUTABLE_PATH, tr("Python executable path (requires restart)"), &m_pythonExecutablePath);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requires restart isn't always. There are some cases that simply reloading the search tab will have immediate effect. But in order to avoid usage confusion, I decided to add this wording.
And pardon, I currently can't afford the time to redesign and make the experience better. Hopefully the current form will be enough for those who demands it.

@Chocobo1 Chocobo1 requested a review from a team September 24, 2023 16:49
@luzpaz
Copy link
Contributor

luzpaz commented Sep 24, 2023

Will this alternate python path be displayed in the About info tab ? (to help troubleshoot/triage problems)

@Chocobo1
Copy link
Member Author

Will this alternate python path be displayed in the About info tab ? (to help troubleshoot/triage problems)

No but the log will record some status.

@xavier2k6
Copy link
Member

Quick test....ran in portable mode. (python 3.11.5 installed, did not have "add to path" checked when installing)

Screenshot 2023-09-25 094613

qbittorrent.log

@Chocobo1
Copy link
Member Author

Quick test....ran in portable mode. (python 3.11.5 installed, did not have "add to path" checked when installing)

Seems all is fine to me. Python is found eventually:

(I) 2023-09-25T09:43:21 - Found Python executable. Name: "C:/Users/PC/AppData/Local/Programs/Python/Python311/python.exe". Version: "3.11.5"

@xavier2k6
Copy link
Member

Seems all is fine to me

To me too.....only posted a screenshot for other to see log messages & where in settings it could be found...

xavier2k6
xavier2k6 previously approved these changes Sep 25, 2023
thalieht
thalieht previously approved these changes Sep 25, 2023
@glassez
Copy link
Member

glassez commented Sep 25, 2023

Too busy. I'll try to review it tomorrow.

@xavier2k6
Copy link
Member

Should close #18557 & probably others too.

@Chocobo1 Chocobo1 dismissed stale reviews from thalieht and xavier2k6 via bcd9b73 September 26, 2023 06:44
@glassez glassez requested a review from a team September 26, 2023 08:40
@Chocobo1 Chocobo1 merged commit b3fda76 into qbittorrent:master Sep 27, 2023
13 checks passed
@Chocobo1 Chocobo1 deleted the python branch September 27, 2023 17:27
@moritzz
Copy link

moritzz commented Oct 11, 2024

This setting has indeed no effect on macOS Sequoia 15.0.1 (24A348). The default Python version is 3.12.6, causing qBittorrent Search to break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Search engine Issues related to the search engine/search plugins functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option in settings to direct to correct Python folder...
6 participants