-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebUI: Support managing web seeds #21055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luzpaz
previously requested changes
Jul 11, 2024
Chocobo1
reviewed
Jul 12, 2024
Piccirello
force-pushed
the
webui-webseeds
branch
2 times, most recently
from
July 15, 2024 20:54
6eeda7d
to
3eb4d0c
Compare
Chocobo1
reviewed
Jul 26, 2024
Piccirello
force-pushed
the
webui-webseeds
branch
5 times, most recently
from
August 4, 2024 21:07
7cd1dc1
to
75be788
Compare
Piccirello
force-pushed
the
webui-webseeds
branch
4 times, most recently
from
August 12, 2024 00:19
cc50dc1
to
fede19b
Compare
glassez
changed the title
Support managing web seeds from WebUI
WebUI: Support managing web seeds
Aug 13, 2024
Chocobo1
reviewed
Aug 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be the last comment from me. Everything else looks good.
This makes it easier to add a context menu to rows.
The GUI referred to these items as both "web seeds" and "URL seeds". This also removes the arbitrary capitalization of "Web" and standardizes on the verb of "Add". Lastly, menu items that open a dialog now end with an ellipsis.
Piccirello
force-pushed
the
webui-webseeds
branch
from
September 12, 2024 16:58
fede19b
to
b2af8da
Compare
Chocobo1
approved these changes
Sep 13, 2024
Ready to merge? |
@Piccirello |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8475.