Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Support managing web seeds #21055

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

Piccirello
Copy link
Member

@Piccirello Piccirello commented Jul 11, 2024

Closes #8475.

Screenshot 2024-07-11 at 12 19 03
Screenshot 2024-07-11 at 12 19 10
Screenshot 2024-07-11 at 12 19 24

@Piccirello Piccirello added the WebUI WebUI-related issues/changes label Jul 11, 2024
luzpaz
luzpaz previously requested changes Jul 11, 2024
src/webui/api/torrentscontroller.cpp Outdated Show resolved Hide resolved
src/webui/www/private/addwebseeds.html Outdated Show resolved Hide resolved
src/webui/www/private/editwebseed.html Outdated Show resolved Hide resolved
@Piccirello Piccirello force-pushed the webui-webseeds branch 2 times, most recently from 6eeda7d to 3eb4d0c Compare July 15, 2024 20:54
@Piccirello Piccirello requested a review from Chocobo1 July 15, 2024 20:55
src/webui/www/private/addwebseeds.html Outdated Show resolved Hide resolved
src/webui/www/private/addwebseeds.html Outdated Show resolved Hide resolved
src/webui/www/private/addwebseeds.html Outdated Show resolved Hide resolved
src/webui/www/private/editwebseed.html Outdated Show resolved Hide resolved
src/webui/www/private/editwebseed.html Outdated Show resolved Hide resolved
src/webui/www/private/editwebseed.html Outdated Show resolved Hide resolved
@Piccirello Piccirello force-pushed the webui-webseeds branch 5 times, most recently from 7cd1dc1 to 75be788 Compare August 4, 2024 21:07
@Piccirello Piccirello force-pushed the webui-webseeds branch 4 times, most recently from cc50dc1 to fede19b Compare August 12, 2024 00:19
@Piccirello Piccirello marked this pull request as ready for review August 12, 2024 00:21
@Piccirello Piccirello requested a review from a team August 12, 2024 00:22
@glassez glassez changed the title Support managing web seeds from WebUI WebUI: Support managing web seeds Aug 13, 2024
Copy link
Member

@Chocobo1 Chocobo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the last comment from me. Everything else looks good.

src/webui/www/private/index.html Outdated Show resolved Hide resolved
This makes it easier to add a context menu to rows.
The GUI referred to these items as both "web seeds" and "URL seeds". This also removes the arbitrary capitalization of "Web" and standardizes on the verb of "Add". Lastly, menu items that open a dialog now end with an ellipsis.
@Chocobo1 Chocobo1 added this to the 5.1 milestone Sep 13, 2024
@Chocobo1 Chocobo1 requested a review from a team September 13, 2024 15:05
@Piccirello
Copy link
Member Author

Ready to merge?

@Chocobo1 Chocobo1 merged commit 81def39 into qbittorrent:master Sep 28, 2024
14 checks passed
@Chocobo1
Copy link
Member

@Piccirello
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow adding HTTP sources from Web UI
3 participants