Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tab stop order in the Options Dialog, Connection page #21856

Conversation

maximmasiutin
Copy link

The tab top order of "Global maximum number of upload slots:" and "Maximum number of upload slots per torrent:" was swapped. To reproduce the issue, focus "Global maximum number of upload slots" and press "Tab". Expected behavior: "Maximum number of upload slots per torrent:" should be focused. Actual behavior: focus jumps to other controls below. This pull request does not add or remove any lines, it just changes order of existing lines.

…stop order of 'Global maximum number of upload slots:' and 'Maximum number of upload slots per torrent:' was swapped
@Chocobo1 Chocobo1 added the GUI GUI-related issues/changes label Nov 16, 2024
@Chocobo1 Chocobo1 requested a review from a team November 17, 2024 07:32
@Chocobo1 Chocobo1 added this to the 5.1 milestone Nov 17, 2024
Copy link
Contributor

@thalieht thalieht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to break anything although the tab stop order is already fixed in master

@glassez
Copy link
Member

glassez commented Nov 17, 2024

Doesn't seem to break anything although the tab stop order is already fixed in master

So what does this PR do then?

@maximmasiutin
Copy link
Author

maximmasiutin commented Nov 17, 2024

Doesn't seem to break anything although the tab stop order is already fixed in master

So what does this PR do then?

It puts the graphical controls in correct order. For example, they were 1, 3, 2, 0. Now they are 0, 1, 2, 3.

@glassez
Copy link
Member

glassez commented Nov 17, 2024

PR title says that it fixes tab stop order but @thalieht says that tab stop order is already correct. So I'm confused...

@xavier2k6
Copy link
Member

Any GUI changes should have screenshots......before & after.

@maximmasiutin
Copy link
Author

These are not the GUI changes. The visible order of the controls is the same, it is only the tab order changes. I can make the screenshots but they are identical.

@Chocobo1
Copy link
Member

This PR is going the right direction. It can correctly specify tab order without explicit <tabstops>.
However, there are more wrong order instances in optionsdialog.ui (and possibly other .ui files). It would be best to change them all in one or two PR.

@maximmasiutin
Copy link
Author

The tab stops I mentioned still are not fixed in 5.0.2. Please consider fixing them or accepting this pull request.

@maximmasiutin
Copy link
Author

The tab stops are not fixed in 5.0.2.

@glassez
Copy link
Member

glassez commented Dec 1, 2024

The tab stops are not fixed in 5.0.2.

Then I guess the fix has just not been backported from master branch to v5_0_x.

Chocobo1 added a commit to Chocobo1/qBittorrent that referenced this pull request Dec 14, 2024
@Chocobo1
Copy link
Member

This PR is going the right direction. It can correctly specify tab order without explicit .
However, there are more wrong order instances in optionsdialog.ui (and possibly other .ui files). It would be best to change them all in one or two PR.

Refer to PR #21996.

Chocobo1 added a commit to Chocobo1/qBittorrent that referenced this pull request Dec 14, 2024
Chocobo1 added a commit to Chocobo1/qBittorrent that referenced this pull request Dec 14, 2024
Chocobo1 added a commit to Chocobo1/qBittorrent that referenced this pull request Dec 15, 2024
@Chocobo1
Copy link
Member

Superseded by #21996.

@Chocobo1 Chocobo1 closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants