-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed tab stop order in the Options Dialog, Connection page #21856
Fixed tab stop order in the Options Dialog, Connection page #21856
Conversation
…stop order of 'Global maximum number of upload slots:' and 'Maximum number of upload slots per torrent:' was swapped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to break anything although the tab stop order is already fixed in master
So what does this PR do then? |
It puts the graphical controls in correct order. For example, they were 1, 3, 2, 0. Now they are 0, 1, 2, 3. |
PR title says that it fixes tab stop order but @thalieht says that tab stop order is already correct. So I'm confused... |
Any GUI changes should have screenshots......before & after. |
These are not the GUI changes. The visible order of the controls is the same, it is only the tab order changes. I can make the screenshots but they are identical. |
This PR is going the right direction. It can correctly specify tab order without explicit |
The tab stops I mentioned still are not fixed in 5.0.2. Please consider fixing them or accepting this pull request. |
The tab stops are not fixed in 5.0.2. |
Then I guess the fix has just not been backported from |
Supersedes qbittorrent#21856.
Refer to PR #21996. |
Supersedes qbittorrent#21856.
Supersedes qbittorrent#21856.
Supersedes qbittorrent#21856.
Superseded by #21996. |
The tab top order of "Global maximum number of upload slots:" and "Maximum number of upload slots per torrent:" was swapped. To reproduce the issue, focus "Global maximum number of upload slots" and press "Tab". Expected behavior: "Maximum number of upload slots per torrent:" should be focused. Actual behavior: focus jumps to other controls below. This pull request does not add or remove any lines, it just changes order of existing lines.