Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI improvements #21916

Merged
merged 9 commits into from
Nov 29, 2024
Merged

WebUI improvements #21916

merged 9 commits into from
Nov 29, 2024

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Nov 25, 2024

  • WebUI: remove child elements directly
  • WebUI: use correct property for selecting child elements
    firstChild will select the first Node which is often not intended (it should be Element instead).
  • WebUI: use idiomatic string methods
  • WebUI: use proper event for handling text changes
  • WebUI: fix wrong event property
  • WebUI: fix invalid style
    initial isn't applicable to borderLeft/borderRight.
  • WebUI: fix checkbox initialization
    Previously the checkbox had all options checked regardless of the stored setting.
  • WebUI: revise Edit Category dialog button text
    The generic "OK" is suitable for more scenarios.
  • WebUI: locate element faster

@Chocobo1 Chocobo1 added WebUI WebUI-related issues/changes Code cleanup Clean up the code while preserving the same outcome labels Nov 25, 2024
@Chocobo1 Chocobo1 added this to the 5.1 milestone Nov 25, 2024
@Chocobo1 Chocobo1 requested a review from a team November 25, 2024 18:37
@thalieht
Copy link
Contributor

Since i have no idea what almost all of these changes do i started testing random stuff.

Caused by this PR:
Filters side panel: tags and trackers text are missing, both light and dark theme.

Not caused by this PR:
Remove torrent dialog: Cancel has no effect and remove doesn't close the dialog
Rename files dialog: Close button has no effect
Edit category dialog: Button is called "Add", add what? Shouldn't it be "Save" or "Ok" like in GUI?

`firstChild` will select the first `Node` which is often not intended (it should be
`Element` instead).
`initial` isn't applicable to `borderLeft`/`borderRight`.
Previously the checkbox had all options checked regardless of the stored
setting.
@Chocobo1 Chocobo1 force-pushed the webui_improve branch 2 times, most recently from 7f7f4ca to 8f7ae81 Compare November 26, 2024 17:19
The generic "OK" is suitable for more scenarios.
@Chocobo1
Copy link
Member Author

Chocobo1 commented Nov 26, 2024

Since i have no idea what almost all of these changes do i started testing random stuff.

Appreciated the testing!

Filters side panel: tags and trackers text are missing, both light and dark theme.

My fault, fixed.

Remove torrent dialog: Cancel has no effect and remove doesn't close the dialog
Rename files dialog: Close button has no effect

I was looking into it too earlier. Those are regression from #21804 and #21892. I've already fixed them in my unpublished branch. I'll submit a PR later. Fixed in PR #21919.

Edit category dialog: Button is called "Add", add what? Shouldn't it be "Save" or "Ok" like in GUI?

I've changed it to "OK".

@Chocobo1 Chocobo1 merged commit 90aecfe into qbittorrent:master Nov 29, 2024
14 checks passed
@Chocobo1 Chocobo1 deleted the webui_improve branch November 29, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code cleanup Clean up the code while preserving the same outcome WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants