-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebUI improvements #21916
WebUI improvements #21916
Conversation
9bb9f8e
to
e790fdc
Compare
e790fdc
to
2af329e
Compare
Since i have no idea what almost all of these changes do i started testing random stuff. Caused by this PR: Not caused by this PR: |
`firstChild` will select the first `Node` which is often not intended (it should be `Element` instead).
`initial` isn't applicable to `borderLeft`/`borderRight`.
Previously the checkbox had all options checked regardless of the stored setting.
7f7f4ca
to
8f7ae81
Compare
The generic "OK" is suitable for more scenarios.
8f7ae81
to
b84a51c
Compare
Appreciated the testing!
My fault, fixed.
I was looking into it too earlier. Those are regression from #21804 and #21892.
I've changed it to "OK". |
firstChild
will select the firstNode
which is often not intended (it should beElement
instead).initial
isn't applicable toborderLeft
/borderRight
.Previously the checkbox had all options checked regardless of the stored setting.
The generic "OK" is suitable for more scenarios.