Don't follow symlink when creating torrents #21944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stalkerok |
|
Tested! 👍 |
How about Linux etc.? Is it a really bad idea to follow symlinks there? |
Now on Windows, it won't follow/include .lnk files when creating torrents. Note that libtorrent will throw errors if we force adding .lnk files. Non-Windows OS will still follow symlinks. Closes qbittorrent#13286.
Chocobo1
force-pushed
the
torrent_creator
branch
from
e5cecd0 to
cd77d71
Compare
It should be OK on linux IMO. |
glassez
approved these changes
Dec 6, 2024
|
@glassez |
glassez
pushed a commit
to glassez/qBittorrent
that referenced
this pull request
Dec 7, 2024
Now on Windows, it won't follow/include .lnk files when creating torrents. Note that libtorrent will throw errors if we force adding .lnk files. Non-Windows OS will still follow symlinks. Closes qbittorrent#13286. PR qbittorrent#21944.
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now on Windows, it won't follow/include .lnk files when creating torrents.
Note that libtorrent will throw errors if we force adding .lnk files.
Closes #13286.