-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .gitignore #21957
Update .gitignore #21957
Conversation
48e6291
to
57ac535
Compare
#==============================================================================# | ||
# Directories to ignore (do not add trailing '/'s, they skip symlinks). | ||
#==============================================================================# | ||
# VS2017 and VSCode config files. | ||
.vscode | ||
.vs | ||
|
||
.idea | ||
.*.sw? | ||
.sw? | ||
|
||
# clangd index. (".clangd" is a config file now, thus trailing slash) | ||
.clangd/ | ||
.cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hold the opinion that these entries should reside in your own .gitignore file, rather than every project you worked on.
See: https://git-scm.com/docs/git-config#Documentation/git-config.txt-coreexcludesFile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering we are using Cmake as build system, it's OK with Cmake build directory?
build* | ||
cmake-build* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering we are using Cmake as build system, it's OK with Cmake build directory?
It is not clear for me about the reasons behind this change. Could you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no file build
that should not be ignored by VCS, so I removed the slash for a wider match. Also add cmake-build
for a regular output directory. Some items above are picked from clang repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no file build that should not be ignored by VCS, so I removed the slash for a wider match. Also add cmake-build for a regular output directory.
That line (build/
) was insisted (very strongly) by someone that claims to be the de facto cmake build directory... however that claim is disputable. To avoid wasting time with the complaints we just allowed it and IMO we shouldn't bother it anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As .vscode/
has been added into .gitignore
before, I thought it's fine to adjust some other editor files. However this work can be set in global git config, thus the modifies in the repo became less necessary. Should be closed as not planned.
build* | ||
cmake-build* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no file build
that should not be ignored by VCS, so I removed the slash for a wider match. Also add cmake-build
for a regular output directory. Some items above are picked from clang repository.
clangd
generates lots of files that should not be added into repository. This commit updates .gitignore file to ignoreclangd
generated file except for its configuration. Also updated some common build and editor files in repository.