Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab order in RSS widget #21999

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix tab order in RSS widget #21999

merged 1 commit into from
Dec 17, 2024

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Dec 14, 2024

Related: #21996 (comment)

@Chocobo1 Chocobo1 added the GUI GUI-related issues/changes label Dec 14, 2024
@Chocobo1 Chocobo1 added this to the 5.1 milestone Dec 14, 2024
@Chocobo1 Chocobo1 requested a review from a team December 14, 2024 18:02
@@ -79,23 +79,19 @@ RSSWidget::RSSWidget(IGUIApplication *app, QWidget *parent)
m_ui->rssDownloaderBtn->setIcon(UIThemeManager::instance()->getIcon(u"downloading"_s, u"download"_s));
#endif

m_articleListWidget = new ArticleListWidget(m_ui->splitterMain);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for fun. It would be enough to just change this line to the next one (and the same for m_feedListWidget):

m_articleListWidget = m_ui->articleListWidget;

@Chocobo1 Chocobo1 merged commit 34c8849 into qbittorrent:master Dec 17, 2024
14 checks passed
@Chocobo1 Chocobo1 deleted the rss_tab branch December 17, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants